linux-kernel - Re: [Keyrings] [PATCH 1/9] Provide a binary to hex conversion function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1410555196.5187.223.camel@dhcp-9-2-203-236.watson.ibm.com>
Date:	Fri, 12 Sep 2014 16:53:16 -0400
From:	Mimi Zohar <zohar@...ux.vnet.ibm.com>
To:	David Howells <dhowells@...hat.com>
Cc:	vgoyal@...hat.com, keyrings@...ux-nfs.org,
	linux-kernel@...r.kernel.org
Subject: Re: [Keyrings] [PATCH 1/9] Provide a binary to hex conversion
 function

On Fri, 2014-09-12 at 21:30 +0100, David Howells wrote: 
> Mimi Zohar <zohar@...ux.vnet.ibm.com> wrote:
> 
> > How about using hex_byte_pack()?
> 
> It doesn't do a bufferful, only one byte.

The following code snippet is pretty common:

for (i = 0; i < count; i++)
bufptr = hex_byte_pack(bufptr, s[i]);

I'm suggesting making bin2hex() a wrapper for calling hex_byte_pack().

Mimi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/