linux-kernel - Re: [PATCH v1 02/13] PCI: Move pci_configure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAErSpo6dF468YjBdYL3A2=cgsB3bAaqNdOL-Fs-EVnz=cJ0MUA@mail.gmail.com>
Date:	Fri, 12 Sep 2014 15:35:10 -0600
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	Rajat Jain <rajatxjain@...il.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	ACPI Devel Maling List <linux-acpi@...r.kernel.org>
Subject: Re: [PATCH v1 02/13] PCI: Move pci_configure_slot() to drivers/pci/probe.c

On Fri, Sep 12, 2014 at 3:31 PM, Yinghai Lu <yinghai@...nel.org> wrote:
> On Fri, Sep 12, 2014 at 11:03 AM, Bjorn Helgaas <bhelgaas@...gle.com> wrote:
>> Move pci_configure_slot() and related functions from
>> drivers/pci/hotplug/pcihp_slot to drivers/pci/probe.c.
>>
>> This is to prepare for doing device configuration during the normal
>> enumeration process instead of just after hot-add.
>>
>> ...

> Would be better if those acpi related code could be moved to
> drivers/pci/pci-acpi.c. and should put pci_configure_device() from
> next patch to pci-acpi.c.

Good point.  I just moved a bunch of the stuff from
drivers/pci/hotplug/acpi_pcihp.c to pci-acpi.h, because acpi_pcihp.c
is not compiled unless CONFIG_PCI_HOTPLUG is set.  And this stuff
probably should go there, too.

> Other that,  for the whole patchset,
>
> Acked-by: Yinghai Lu <yinghai@...nel.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/