lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140913163749.GK7960@sirena.org.uk>
Date: Sat, 13 Sep 2014 09:37:49 -0700
From: Mark Brown <broonie@...nel.org>
To: Jianqun <jay.xu@...k-chips.com>
Cc: heiko@...ech.de, lgirdwood@...il.com, perex@...ex.cz,
tiwai@...e.de, linux-arm-kernel@...ts.infradead.org,
linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
alsa-devel@...a-project.org, huangtao@...k-chips.com,
cf@...k-chips.com
Subject: Re: [PATCH 5/5] ASoC: rockchip-i2s: enable "hclk" for rockchip I2S
controller
On Sat, Sep 13, 2014 at 08:43:13AM +0800, Jianqun wrote:
> +++ b/sound/soc/rockchip/rockchip_i2s.c
> @@ -423,6 +423,11 @@ static int rockchip_i2s_probe(struct platform_device *pdev)
> dev_err(&pdev->dev, "Can't retrieve i2s bus clock\n");
> return PTR_ERR(i2s->hclk);
> }
> + ret = clk_prepare_enable(i2s->hclk);
> + if (ret) {
> + dev_err(i2s->dev, "hclock enable failed %d\n", ret);
> + return ret;
> + }
BTW: you're also missing a clk_disable_unprepare() in the remove path
here, please send a followup fixing that.
Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)
Powered by blists - more mailing lists