linux-kernel - Re: [PATCH] netdev: octeon_mgmt: ISO C90 forbids mixed declarations and code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140913.160302.698126980021738731.davem@davemloft.net>
Date:	Sat, 13 Sep 2014 16:03:02 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	xypron.glpk@....de, david.daney@...ium.com, luka@...nwrt.org,
	willemb@...gle.com, rmk+kernel@....linux.org.uk,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] netdev: octeon_mgmt: ISO C90 forbids mixed
 declarations and code

From: Joe Perches <joe@...ches.com>
Date: Sat, 13 Sep 2014 12:11:12 -0700

> On Sat, 2014-09-13 at 21:05 +0200, Heinrich Schuchardt wrote:
>> Compiling with OCTEON_MGMT_ETHERNET gives a warning
>> drivers/net/ethernet/octeon/octeon_mgmt.c:295:4:
>> warning: ISO C90 forbids mixed declarations and code
>> [-Wdeclaration-after-statement]
> 
> Maybe better to move the memset after the declaration.

Totally agree, keep the variable in the innermost scope
in which it is used.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/