lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <5414AFA6.9060904@cogentembedded.com> Date: Sat, 13 Sep 2014 23:57:10 +0300 From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> To: Jianqun <jay.xu@...k-chips.com>, heiko@...ech.de, lgirdwood@...il.com, broonie@...nel.org, perex@...ex.cz, tiwai@...e.de, linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org, alsa-devel@...a-project.org CC: huangtao@...k-chips.com, cf@...k-chips.com Subject: Re: [PATCH 4/5] ASoC: rockchip-i2s: fix registers' property of rockchip i2s controller Hello. On 9/13/2014 3:42 AM, Jianqun wrote: > Reference rockchip I2S controller TRM, modify some registers' property > I2S_FIFOLR: read / write, but not volatile, not precious > I2S_INTSR: read / write > I2S_CLR: volatile, register value will be cleared by read > Test on RK3288 with max98090. > Signed-off-by: Jianqun Xu <jay.xu@...k-chips.com> > --- > sound/soc/rockchip/rockchip_i2s.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c > index 1b9b404..6595383 100644 > --- a/sound/soc/rockchip/rockchip_i2s.c > +++ b/sound/soc/rockchip/rockchip_i2s.c [...] > @@ -385,8 +387,6 @@ static bool rockchip_i2s_volatile_reg(struct device *dev, unsigned int reg) > static bool rockchip_i2s_precious_reg(struct device *dev, unsigned int reg) > { > switch (reg) { > - case I2S_FIFOLR: > - return true; > default: > return false; > } Shouldn't this be folded into simple *return* false now? WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists