linux-kernel - [PATCH] sd: assign more appropriate log levels for two messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CABz95_CLet-UzaUq-z1pRMvEpzkCTYbKbYWBcS0dQZ1iYGryzg@mail.gmail.com>
Date:	Sat, 13 Sep 2014 22:25:14 +0100
From:	Steven Honeyman <stevenhoneyman@...il.com>
To:	"James E.J. Bottomley" <JBottomley@...allels.com>
Cc:	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] sd: assign more appropriate log levels for two messages

KERN_ERR is too high severity for an "assumption" message, so I moved
them down to KERN_WARNING

Signed-off-by: Steven Honeyman <stevenhoneyman@...il.com>
---
 drivers/scsi/sd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 2c2041c..bb7d6e9 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -2468,7 +2468,7 @@ sd_read_cache_type(struct scsi_disk *sdkp,
unsigned char *buffer)
             }
         }

-        sd_first_printk(KERN_ERR, sdkp, "No Caching mode page found\n");
+        sd_first_printk(KERN_WARNING, sdkp, "No Caching mode page found\n");
         goto defaults;

     Page_found:
@@ -2518,7 +2518,7 @@ defaults:
                 "Assuming drive cache: write back\n");
         sdkp->WCE = 1;
     } else {
-        sd_first_printk(KERN_ERR, sdkp,
+        sd_first_printk(KERN_WARNING, sdkp,
                 "Assuming drive cache: write through\n");
         sdkp->WCE = 0;
     }
-- 
2.1.0
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/