linux-kernel - Re: [PATCH v2 4/6] mm: introduce common page state for ballooned memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALYGNiNg5yLbAvqwG3nPqWZHkqXc1-3p4yqdP2Eo2rNJbRo0rg@mail.gmail.com>
Date:	Sat, 13 Sep 2014 12:22:23 +0400
From:	Konstantin Khlebnikov <koct9i@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Konstantin Khlebnikov <k.khlebnikov@...sung.com>,
	Rafael Aquini <aquini@...hat.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	Andrey Ryabinin <ryabinin.a.a@...il.com>,
	Sasha Levin <sasha.levin@...cle.com>
Subject: Re: [PATCH v2 4/6] mm: introduce common page state for ballooned memory

On Sat, Sep 13, 2014 at 9:42 AM, Andrew Morton
<akpm@...ux-foundation.org> wrote:
> On Sat, 13 Sep 2014 09:26:49 +0400 Konstantin Khlebnikov <koct9i@...il.com> wrote:
>
>> >
>> > Did we really need to put the BalloonPages count into per-zone vmstat,
>> > global vmstat and /proc/meminfo?  Seems a bit overkillish - why so
>> > important?
>>
>> Balloon grabs random pages, their distribution among numa nodes might
>> be important.
>> But I know nobody who uses numa-aware vm together with ballooning.
>>
>> Probably it's better to drop per-zone vmstat and line from meminfo,
>> global vmstat counter should be enough.
>
> Yes, the less we add the better - we can always add stuff later if
> there is a demonstrated need.

Ok. (I guess incremental patches are more convenient for you)
Here is two fixes which remove redundant per-zone counters and adds
three vmstat counters: "balloon_inflate", "balloon_deflate" and
"balloon_migrate".

This statistic seems more useful than current state snapshot.
Size of balloon is just a difference between "inflate" and "deflate".

>
>> >
>> > Consuming another page flag is a big deal.  We keep on nearly running
>> > out and one day we'll run out for real.  page-flags-layout.h is
>> > incomprehensible.  How many flags do we have left (worst-case) with this
>> > change?  Is there no other way?  Needs extraordinary justification,
>> > please.
>>
>> PageBalloon is not a page flags, it's like PageBuddy -- special state
>> of _mapcount (-256 in this case).
>> The same was in v1 and is written in the comment above.
>
> oop sorry, I got confused about KPF_BALLOON.

Download attachment "mm-balloon_compaction-use-common-page-ballooning-use-vmstat-counters" of type "application/octet-stream" (2701 bytes)

Download attachment "mm-introduce-common-page-state-for-ballooned-memory-vmstat-counters" of type "application/octet-stream" (5083 bytes)