linux-kernel - Re: [PATCH] net: bpf: correctly handle errors in sk_attach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1410600293.25850.2.camel@localhost>
Date:	Sat, 13 Sep 2014 11:24:53 +0200
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	Sasha Levin <sasha.levin@...cle.com>
Cc:	davem@...emloft.net, ast@...mgrid.com, keescook@...omium.org,
	dborkman@...hat.com, spender@...ecurity.net,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: bpf: correctly handle errors in sk_attach_filter()

On Sa, 2014-09-13 at 00:06 -0400, Sasha Levin wrote:
> Commit "net: bpf: make eBPF interpreter images read-only" has changed bpf_prog
> to be vmalloc()ed but never handled some of the errors paths of the old code.
> 
> On error within sk_attach_filter (which userspace can easily trigger), we'd
> kfree() the vmalloc()ed memory, and leak the internal bpf_work_struct.
> 
> Signed-off-by: Sasha Levin <sasha.levin@...cle.com>

Yeah, thanks, we missed that somehow.

Acked-by: Hannes Frederic Sowa <hannes@...essinduktion.org>

Bye,
Hannes


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/