lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140913105914.GD26281@piout.net> Date: Sat, 13 Sep 2014 12:59:14 +0200 From: Alexandre Belloni <alexandre.belloni@...e-electrons.com> To: Ezequiel Garcia <ezequiel@...guardiasur.com.ar> Cc: Josh Wu <josh.wu@...el.com>, Brian Norris <computersforpeace@...il.com>, Boris Brezillon <boris.brezillon@...e-electrons.com>, Nicolas Ferre <nicolas.ferre@...el.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>, David Woodhouse <dwmw2@...radead.org>, linux-arm-kernel <linux-arm-kernel@...ts.infradead.org> Subject: Re: [PATCHv5] mtd: nand: atmel_nand: retrieve NFC clock Hi, On 13/09/2014 at 10:26:18 +0100, Ezequiel Garcia wrote : > > + nfc->clk = devm_clk_get(&pdev->dev, NULL); > > + if (!IS_ERR(nfc->clk)) { > > + ret = clk_prepare_enable(nfc->clk); > > + if (ret) > > + return ret; > > + } else { > > + dev_warn(&pdev->dev, "NFC clock missing, update your Device Tree"); > > Looks much better now thanks. If the clock is not really optional, you > can consider this a firmware bug. We've used FW_BUG messages for these > cases > (see vim drivers/watchdog/orion_wdt.c), so you could write something like: > > dev_warn(..., FW_BUG "devicetree clock missing"); > Yeah, I've considered using FW_WARN like Thomas suggested but I'm not sure it really relates to device tree. Apart from x86, FW_WARN and FW_BUG are only used on mvebu stuff ;) -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists