linux-kernel - Re: [PATCH] Staging: android: ion: fix coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140914165018.GA2821@kroah.com>
Date:	Sun, 14 Sep 2014 09:50:18 -0700
From:	Greg KH <greg@...ah.com>
To:	Sorin Facaoaru <work@...in.cc>
Cc:	ccross@...roid.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: android: ion: fix coding style

First off, thanks for the patches.

But, they need some tweaks before I can accept them.

You sent a bunch of patches, all with the same exact subject, with no
hint of which order they should be applied in, or what exactly they do.

On Sat, Sep 13, 2014 at 04:46:10PM -0700, Sorin Facaoaru wrote:
> - add line after declaration 
> - remove return statement in empty void function

For this patch, you are doing two different things, in the same file,
that should be two different patches.  But you might be able to merge
them with your other patches.

Make your patches do "just one thing" from a logical point of view.

For example, you could have a patch titled:
	[PATCH 01/05] staging: android: ion: remove unneeded returns

that just removed the unneeded return statemnents for all of the ion
files.

Then 4 other patches that do 4 other "logical" things, telling me what
order to apply them in.

Can you please fix up all of your recent submissions and resend in that
format?

> Signed-off-by: Sorin Facaoaru <work@...in.cc> 

You have trailing whitespace here :(

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/