lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 15 Sep 2014 11:23:46 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Peng Tao <bergwolf@...il.com>, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] staging: lustre: lustre: libcfs: debug.c: Cleaning up unnecessary use of memset in conjunction with strncpy On Sun, Sep 14, 2014 at 06:03:16PM +0200, Rickard Strandqvist wrote: > Using memset before strncpy just to ensure a trailing null > character is an unnecessary double writing of a string > You really should make a function which pads and NUL terminates. I've said this before, of course, but you haven't even tried. I can't get excited about these cleanups which open code NUL termination every where. They are risky and have introduced bugs before. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists