linux-kernel - Re: [PATCH] mfd: intel_soc_pmic: Add CONFIG_PM_SLEEP check for suspend_fn/resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140915230723.GK25162@lee--X1>
Date:	Tue, 16 Sep 2014 00:07:23 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Jaewon Kim <jaewon02.kim@...sung.com>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>, linux-kernel@...r.kernel.org,
	Chanwoo Choi <cw00.choi@...sung.com>
Subject: Re: [PATCH] mfd: intel_soc_pmic: Add CONFIG_PM_SLEEP check for
 suspend_fn/resume_fn

On Fri, 12 Sep 2014, Jaewon Kim wrote:

> This patch fix warning message with CONFIG_PM_SLEEP disabled
> If CONFIG_PM_SLEEP is not enabled we receive the following warning message:
> 
> drivers/mfd/intel_soc_pmic_core.c:118:12:
>  warning: 'intel_soc_pmic_suspend' defined but not used
> 
> Signed-off-by: Jaewon Kim <jaewon02.kim@...sung.com>
> ---
>  drivers/mfd/intel_soc_pmic_core.c |    2 ++
>  1 file changed, 2 insertions(+)

Applied, thanks.

> diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c
> index 2720922..df7b064 100644
> --- a/drivers/mfd/intel_soc_pmic_core.c
> +++ b/drivers/mfd/intel_soc_pmic_core.c
> @@ -115,6 +115,7 @@ static void intel_soc_pmic_shutdown(struct i2c_client *i2c)
>  	return;
>  }
>  
> +#if defined(CONFIG_PM_SLEEP)
>  static int intel_soc_pmic_suspend(struct device *dev)
>  {
>  	struct intel_soc_pmic *pmic = dev_get_drvdata(dev);
> @@ -132,6 +133,7 @@ static int intel_soc_pmic_resume(struct device *dev)
>  
>  	return 0;
>  }
> +#endif
>  
>  static SIMPLE_DEV_PM_OPS(intel_soc_pmic_pm_ops, intel_soc_pmic_suspend,
>  			 intel_soc_pmic_resume);

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/