lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 15 Sep 2014 10:26:01 +0000 From: Alexey Brodkin <Alexey.Brodkin@...opsys.com> To: "acme@...stprotocols.net" <acme@...stprotocols.net>, "jolsa@...nel.org" <jolsa@...nel.org> CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "dev@...yps.com" <dev@...yps.com>, "peterz@...radead.org" <peterz@...radead.org>, "acme@...hat.com" <acme@...hat.com>, "bp@...e.de" <bp@...e.de>, Vineet Gupta <Vineet.Gupta1@...opsys.com> Subject: Re: [PATCH] perf tools: fix type mismatch - long vs __statfs_word Hi Arnaldo, Jiri, > On Wednesday 13 August 2014 10:34 PM, Alexey Brodkin wrote: > > From "include/uapi/asm-generic/statfs.h" it is seen that "statfs.f_type" is of > > type "__statfs_word" which in its turn is "__u32" (unsigned int) for 32-bit > > systems. > > > > So in case of compilation with "-Werror" following breakage happens: > > --->--- > > fs.c: In function ‘fs__valid_mount’: > > fs.c:76:24: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] > > else if (st_fs.f_type != magic) > > ^ > > cc1: all warnings being treated as errors > > --->--- > > > > Note that now when fs.c is in "lib/api/fs" and in "tools/lib/api/Makefile" > > CFLAGS has hard-coded "-Werror" this is inevitable even if one builds "perf" > > with "WERROR=0". > > I'm wondering if there's a chance to get this patch accepted because for now perf building from 3.15 kernels onward is broken. Regards, Alexey
Powered by blists - more mailing lists