linux-kernel - Re: 3.15 Regression Due to goldfish bus Commit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140915020957.GA8203@kroah.com>
Date:	Sun, 14 Sep 2014 19:09:57 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
Cc:	Mark S <mstanovich15@...il.com>, linux-kernel@...r.kernel.org,
	Octavian Purdila <octavian.purdila@...el.com>,
	Jun Tian <jun.j.tian@...el.com>,
	Alan Cox <alan@...ux.intel.com>
Subject: Re: 3.15 Regression Due to goldfish bus Commit

On Mon, Sep 15, 2014 at 12:12:19AM +0100, One Thousand Gnomes wrote:
> On Sun, 14 Sep 2014 14:57:37 -0700
> Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:
> 
> > On Sun, Sep 14, 2014 at 05:38:55PM -0400, Mark S wrote:
> > > Commit c1bc97f8f498a2bfab63ceef761fb0e88ef7c065 causes a gateway x86 laptop,
> > > booting from a usb device, to hang before the kernel completes booting. The
> > > offending commit was found using git bisect. Reverting the commit fixes the
> > > problem on 3.16.2.
> > > 
> > > The error resulting in the hang may not be a concern since the goldfish option
> > > is not needed and should probably not be selected. I'm mentioning this problem
> > > just in case it is unexpected behavior and it is worth fixing. Maybe the
> > > goldfish option should not be selectable for a similar configuration as mine?
> > 
> > There should be some other type of run-time option to not have this code
> > run if it is found to not be running on the goldfish virtual machine.
> > 
> > Anyone know how to do that?
> 
> I asked last time it was reported and the time before (it comes up every
> year or two). There is no sane documented way to detect the Goldfish
> virtual machine as distinct from anything else.
> 
> We could hide Goldfish under expert ?

No, that would be a mess.  Just put a big warning on the option, no one
should be enabling it if they don't want it, the config option text
should say this.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/