lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 15 Sep 2014 19:58:56 +0800 From: Shengjiu Wang <shengjiu.wang@...escale.com> To: Fabio Estevam <festevam@...il.com> CC: Shawn Guo <shawn.guo@...escale.com>, Sascha Hauer <kernel@...gutronix.de>, Russell King <linux@....linux.org.uk>, "robh+dt@...nel.org" <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>, Mark Rutland <mark.rutland@....com>, Ian Campbell <ijc+devicetree@...lion.org.uk>, "Kumar Gala" <galak@...eaurora.org>, linux-kernel <linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org> Subject: Re: [PATCH V1 1/3] ARM: clk-imx6sl: refine clock tree for SSI Hi fabio, shawn. On Fri, Sep 12, 2014 at 01:43:39PM -0300, Fabio Estevam wrote: > On Fri, Sep 12, 2014 at 1:35 PM, Fabio Estevam <festevam@...il.com> wrote: > > On Tue, Sep 9, 2014 at 6:13 AM, Shengjiu Wang > > <shengjiu.wang@...escale.com> wrote: > >> Each SSI has "ssi", "ssi_ipg" clocks, and they share same gate bits. > >> > >> Signed-off-by: Shengjiu Wang <shengjiu.wang@...escale.com> > > > > This patch breaks audio playback on imx6q-sabresd: > > > > root@...escale /$ aplay /home/clarinet.wav > > Playing WAVE '/home/clarinet.wav' : Signed 16 bit Little Endian, Rate 44100 Hz, > > Mono > > underrun!!! (at least -1585992.581 ms long) > > underrun!!! (at least -1585992.585 ms long) > > underrun!!! (at least -1585992.586 ms long) > > underrun!!! (at least -1585992.586 ms long) > > underrun!!! (at least -1585992.586 ms long) > > underrun!!! (at least -1585992.586 ms long) > > underrun!!! (at least -1585992.586 ms long) > > underrun!!! (at least -1585992.586 ms long) > > underrun!!! (at least -1585992.586 ms long) > > underrun!!! (at least -1585992.586 ms long) > > > > If I revert this commit, then I am able to play it well again. > > Ops, I replied in the wrong patch. > > The one that breaks imx6q-sabresd is: > > commit 48e1c2255 "ARM: clk-imx6q: refine clock tree for SSI" I add IMX6QDL_CLK_SSIx in this patch, which use share count with IMX6QDL_CLK_SSIx_IPG. The SSI driver sound/soc/fsl/fsl_ssi.c will enable IMX6QDL_CLK_SSIx_IPG clock in probe, but don't disable it. In the end of kernel boot up, some one(it is not ssi driver, maybe is the clock tree) will disable the IMX6QDL_CLK_SSIx clock, which is not enabled. IMX6QDL_CLK_SSIx_IPG share the enable/disable bit with IMX6QDL_CLK_SSIx, So IMX6QDL_CLK_SSIx_IPG is disabled, the aplay will fail. Is this the issue of imx_clk_gate2_shared()? When we want to disable IMX6QDL_CLK_SSIx, but IMX6QDL_CLK_SSIx_IPG is enabled, can IMX6QDL_CLK_SSIx be disabled? Shawn How do you think about this? best regards wang shengjiu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists