linux-kernel - Re: [PATCH v3 3/3] sched: BUG when stack end location is over written

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1410748793.24738.2.camel@concordia>
Date:	Mon, 15 Sep 2014 12:39:53 +1000
From:	Michael Ellerman <mpe@...erman.id.au>
To:	Mike Galbraith <umgwanakikbuti@...il.com>
Cc:	Aaron Tomlin <atomlin@...hat.com>, peterz@...radead.org,
	dzickus@...hat.com, jcastillo@...hat.com, riel@...hat.com,
	x86@...nel.org, akpm@...ux-foundation.org, minchan@...nel.org,
	bmr@...hat.com, prarit@...hat.com, oleg@...hat.com,
	rostedt@...dmis.org, linux-kernel@...r.kernel.org,
	hannes@...xchg.org, mingo@...hat.com,
	aneesh.kumar@...ux.vnet.ibm.com, akpm@...gle.com, jgh@...hat.com,
	linuxppc-dev@...ts.ozlabs.org, tglx@...utronix.de,
	pzijlstr@...hat.com
Subject: Re: [PATCH v3 3/3] sched: BUG when stack end location is over
 written

On Fri, 2014-09-12 at 12:58 +0200, Mike Galbraith wrote:
> On Fri, 2014-09-12 at 10:44 +0100, Aaron Tomlin wrote: 
> > On Fri, Sep 12, 2014 at 02:06:57PM +1000, Michael Ellerman wrote:
> > > On Thu, 2014-09-11 at 16:41 +0100, Aaron Tomlin wrote:
> > > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> > > > index a285900..2a8280a 100644
> > > > --- a/lib/Kconfig.debug
> > > > +++ b/lib/Kconfig.debug
> > > > @@ -824,6 +824,18 @@ config SCHEDSTATS
> > > >  	  application, you can say N to avoid the very slight overhead
> > > >  	  this adds.
> > > >  
> > > > +config SCHED_STACK_END_CHECK
> > > > +	bool "Detect stack corruption on calls to schedule()"
> > > > +	depends on DEBUG_KERNEL
> > > > +	default y
> > > 
> > > Did you really mean default y?
> > > 
> > > Doing so means it will be turned on more or less everywhere, which defeats the
> > > purpose of having a config option in the first place.
> > 
> > Only if Kconfig CONFIG_DEBUG_KERNEL is enabled in the first place.
> 
> Which is likely enabled just about everywhere on the planet.

Yes, including all distros I'm aware of.

cheers


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/