linux-kernel - [PATCH] Infiniband coding mistake fixed.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 15 Sep 2014 21:22:20 +0800
From:	"eagle.rtlinux" <eagle.rtlinux@...il.com>
To:	linux-kernel@...r.kernel.org
CC:	infinipath@...el.com, roland@...nel.org, sean.hefty@...el.com,
	hal.rosenstock@...il.com, linux-rdma@...r.kernel.org,
	eagle.rtlinux@...il.com
Subject: [PATCH] Infiniband coding mistake fixed.

hello,

The last parameter of get_user_pages should be a array of pointers to 
vmas corresponding to each page. Through this coding mistake can not 
cause some problem now, it is a potential time bomb.

Signed-off-by: Yang Honggang <eagle.rtlinux@...il.com>
---
  drivers/infiniband/hw/qib/qib_user_pages.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/qib/qib_user_pages.c 
b/drivers/infiniband/hw/qib/qib_user_pages.c
index 2bc1d2b..e93d459 100644
--- a/drivers/infiniband/hw/qib/qib_user_pages.c
+++ b/drivers/infiniband/hw/qib/qib_user_pages.c
@@ -69,7 +69,7 @@ static int __qib_get_user_pages(unsigned long 
start_page, size_t num_pages,
          ret = get_user_pages(current, current->mm,
                       start_page + got * PAGE_SIZE,
                       num_pages - got, 1, 1,
-                     p + got, vma);
+                     p + got, vma + got);
          if (ret < 0)
              goto bail_release;
      }
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/