linux-kernel - Re: [Patch v4 1/2] freezer: check OOM kill while being frozen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4489261.oHB60C5hao@vostro.rjw.lan>
Date:	Mon, 15 Sep 2014 05:34:36 +0200
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Tejun Heo <tj@...nel.org>
Cc:	Michal Hocko <mhocko@...e.cz>,
	Cong Wang <xiyou.wangcong@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	David Rientjes <rientjes@...gle.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [Patch v4 1/2] freezer: check OOM kill while being frozen

On Monday, September 15, 2014 09:56:57 AM Tejun Heo wrote:
> On Sun, Sep 14, 2014 at 06:43:31PM +0200, Rafael J. Wysocki wrote:
> > On Saturday, September 13, 2014 08:59:35 AM Tejun Heo wrote:
> > > Doesn't this mean that if PM freezing and OOM killing race each other,
> > > the system may hang?  Driver PM operation may try to allocate memory
> > > -> triggers OOM -> OOM killer selects an already frozen task ->
> > > nothing happens.  I wonder whether OOM killing and PM operations
> > > should be mutually exclusive at a higher level.  e.g. make OOM killing
> > > always override freezing but let hibernation abort operation before
> > > taking snapshot if OOM killing has happened since the beginning of the
> > > PM operation.
> > 
> > As Michal noted, we do oom_killer_disable() in freeze_processes(), so the
> > scenario above cannot actually happen to my eyes.  Or am I missing anything?
> 
> Ah, okay, that's better but it doesn't seem enough.  It does prevent
> new invocations of the oom killer but doesn't do anything if oom
> killing is already in progress.  If we do block out oom killing
> properly across PM freeze/thaw, it shoud be fine.

OK, so my assumption was that oom_killer_disable() would wait for the OOM
killing in progress to complete.  Alternatively, it can return an error code
if OOM killing is in progress and we can simply fail the freezing in that
case.

Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/