lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 15 Sep 2014 15:54:11 +0100 From: Catalin Marinas <catalin.marinas@....com> To: Olof Johansson <olof@...om.net> Cc: "hanjun.guo@...aro.org" <hanjun.guo@...aro.org>, "Rafael J. Wysocki" <rjw@...ysocki.net>, Mark Rutland <Mark.Rutland@....com>, "grant.likely@...aro.org" <grant.likely@...aro.org>, Will Deacon <Will.Deacon@....com>, "graeme.gregory@...aro.org" <graeme.gregory@...aro.org>, Arnd Bergmann <arnd@...db.de>, Sudeep Holla <Sudeep.Holla@....com>, "jcm@...hat.com" <jcm@...hat.com>, Jason Cooper <jason@...edaemon.net>, Marc Zyngier <Marc.Zyngier@....com>, Bjorn Helgaas <bhelgaas@...gle.com>, Daniel Lezcano <daniel.lezcano@...aro.org>, Mark Brown <broonie@...nel.org>, Rob Herring <robh@...nel.org>, Robert Richter <rric@...nel.org>, Lv Zheng <lv.zheng@...el.com>, Robert Moore <robert.moore@...el.com>, Lorenzo Pieralisi <Lorenzo.Pieralisi@....com>, Liviu Dudau <Liviu.Dudau@....com>, Randy Dunlap <rdunlap@...radead.org>, Charles Garcia-Tobin <Charles.Garcia-Tobin@....com>, "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linaro-acpi@...ts.linaro.org" <linaro-acpi@...ts.linaro.org>, Tomasz Nowicki <tomasz.nowicki@...aro.org> Subject: Re: [PATCH v4 09/18] ARM64 / ACPI: Parse FADT table to get PSCI flags for PSCI init On Mon, Sep 15, 2014 at 07:38:08AM +0100, Olof Johansson wrote: > On Fri, Sep 12, 2014 at 10:00:07PM +0800, Hanjun Guo wrote: > > +static int __init acpi_parse_fadt(struct acpi_table_header *table) > > +{ > > + struct acpi_table_fadt *fadt = (struct acpi_table_fadt *)table; > > + > > + /* > > + * Revision in table header is the FADT Major revision, > > + * and there is a minor revision of FADT which was introduced > > + * by ACPI 5.1, we only deal with ACPI 5.1 or higher revision > > + * to get arm boot flags, or we will disable ACPI. > > + */ > > + if (table->revision > 5 || > > + (table->revision == 5 && fadt->minor_revision >= 1)) > > + return 0; > > The commend and code disagree. The code says 5.1 or newer, while the comment say > _only_ 5.1. One or the other needs to change. I don't think the comment and code disagree, it says "we only deal with ACPI 5.1 _or_ higher revision". But since you mention it and following my other thread with Grant, I think at least for now we should make this check 5.1 only. -- Catalin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists