lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 15 Sep 2014 16:56:06 +0200 From: Krzysztof Kozlowski <k.kozlowski@...sung.com> To: Javier Martinez Canillas <javier@...hile0.org> Cc: Ben Dooks <ben-linux@...ff.org>, Kukjin Kim <kgene.kim@...sung.com>, Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>, Mark Rutland <mark.rutland@....com>, Ian Campbell <ijc+devicetree@...lion.org.uk>, Kumar Gala <galak@...eaurora.org>, Russell King <linux@....linux.org.uk>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-samsung-soc@...r.kernel.org" <linux-samsung-soc@...r.kernel.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, Linux Kernel <linux-kernel@...r.kernel.org>, Kyungmin Park <kyungmin.park@...sung.com>, Marek Szyprowski <m.szyprowski@...sung.com>, Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>, Tomasz Figa <tomasz.figa@...il.com> Subject: Re: [PATCH] ARM: dts: Add Maxim 77693 PMIC to the Trats2 board On pon, 2014-09-15 at 16:36 +0200, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On Fri, Sep 12, 2014 at 2:03 PM, Krzysztof Kozlowski > <k.kozlowski@...sung.com> wrote: > > + i2c_max77693: i2c-gpio-1 { > > + compatible = "i2c-gpio"; > > + gpios = <&gpm2 0 0>, <&gpm2 1 0 >; > > Can you please include <dt-bindings/gpio/gpio.h> and use > GPIO_ACTIVE_HIGH instead of 0 here for the type/level flags? Sure! > > > + i2c-gpio,delay-us = <2>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + status = "okay"; > > + > > + max77693@66 { > > + compatible = "maxim,max77693"; > > + interrupt-parent = <&gpx1>; > > + interrupts = <5 2>; > > + reg = <0x66>; > > + > > + regulators { > > + esafeout1_reg: esafeout@1 { > > + regulator-compatible = "ESAFEOUT1"; > > According to Documentation/devicetree/bindings/regulator/regulator.txt, > the "regulator-compatible" DT property has been deprecated in favor of > just using the regulator node's name. OK > > > + regulator-name = "ESAFEOUT1"; > > + }; > > + esafeout2_reg: esafeout@2 { > > + regulator-compatible = "ESAFEOUT2"; > > + regulator-name = "ESAFEOUT2"; > > + }; > > + charger_reg: charger@0 { > > + regulator-compatible = "CHARGER"; > > + regulator-name = "CHARGER"; > > + regulator-min-microamp = <60000>; > > + regulator-max-microamp = <2580000>; > > + }; > > + }; > > + }; > > + }; > > + > > mmc@...50000 { > > num-slots = <1>; > > supports-highspeed; > > > > Once those two issues are addressed, feel free to add my > > Reviewed-by: Javier Martinez Canillas <javier.martinez@...labora.co.uk> Thank you for feedback! Best regards, Krzysztof > > Best regards, > Javier -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists