linux-kernel - Re: [PATCH v3 1/4] PM / Runtime: Add getter for quering the IRQ safe option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 15 Sep 2014 17:11:33 +0200
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	Russell King <linux@....linux.org.uk>,
	Dan Williams <dan.j.williams@...el.com>,
	Vinod Koul <vinod.koul@...el.com>,
	linux-kernel@...r.kernel.org, dmaengine@...r.kernel.org,
	Ulf Hansson <ulf.hansson@...aro.org>,
	Grant Likely <grant.likely@...aro.org>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Michal Simek <michal.simek@...inx.com>,
	linux-pm@...r.kernel.org,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Subject: Re: [PATCH v3 1/4] PM / Runtime: Add getter for quering the IRQ safe
 option

On pon, 2014-09-15 at 10:57 -0400, Alan Stern wrote:
> On Mon, 15 Sep 2014, Krzysztof Kozlowski wrote:
> 
> > Add a simple getter pm_runtime_is_irq_safe() for quering whether runtime
> > PM IRQ safe was set or not.
> > 
> > Various bus drivers implementing runtime PM may use choose to suspend
> > differently based on IRQ safeness status of child driver (e.g. do not
> > unprepare the clock if IRQ safe is not set).
> > 
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> > ---
> >  include/linux/pm_runtime.h | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/include/linux/pm_runtime.h b/include/linux/pm_runtime.h
> > index 367f49b9a1c9..44d74f0f182e 100644
> > --- a/include/linux/pm_runtime.h
> > +++ b/include/linux/pm_runtime.h
> > @@ -128,6 +128,11 @@ static inline void pm_runtime_mark_last_busy(struct device *dev)
> >  	ACCESS_ONCE(dev->power.last_busy) = jiffies;
> >  }
> >  
> > +static inline bool pm_runtime_is_irq_safe(struct device *dev)
> > +{
> > +	return dev->power.irq_safe;
> > +}
> > +
> 
> If you add something to the runtime PM API, you must update the 
> documentation file (Documentation/power/runtime_pm.txt) 
> correspondingly.


Thank you for pointing this out. I'll fix this and re-spin.

Best regards,
Krzysztof

> 
> Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/