linux-kernel - Re: [PATCH 1/1] checkpatch: fix perl v5.20 warning: useless use of greediness modifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 15 Sep 2014 08:19:29 -0700
From:	Joe Perches <joe@...ches.com>
To:	Roman Pen <r.peniaev@...il.com>
Cc:	Andy Whitcroft <apw@...onical.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] checkpatch: fix perl v5.20 warning: useless use of
 greediness modifier

On Tue, 2014-09-16 at 00:12 +0900, Roman Pen wrote:
> on my perl v5.20 I got:
>   Useless use of greediness modifier '+' in regex; marked by
>   <-- HERE in m/(^\+.*) {8,8}+ <-- HERE \t/ at ./scripts/checkpatch.pl line 2427.
> 
> greediness modifier '+' in construction '\s{8,8}+' does not make
> any sense, because we already specify how many chars do we expect.
> 
> Also we can avoid second ',8' and use simple '\s{8}'.

Thanks Roman, it's already fixed in -next.

http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/scripts/checkpatch.pl?id=66cb4ee0e52ca721f609fd5eec16187189ae5fda


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/