lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 15 Sep 2014 16:20:54 +0100 From: Matt Fleming <matt@...sole-pimps.org> To: linux-efi@...r.kernel.org Cc: linux-kernel@...r.kernel.org, Matt Fleming <matt.fleming@...el.com>, Ulf Winkelvos <ulf@...kelvos.de>, Andre Müller <andre.muller@....de> Subject: [PATCH] x86/efi: Delete misleading efi_printk() error message From: Matt Fleming <matt.fleming@...el.com> A number of people are reporting seeing the "setup_efi_pci() failed!" error message in what used to be a quiet boot, https://bugzilla.kernel.org/show_bug.cgi?id=81891 The message isn't all that helpful because setup_efi_pci() can return a non-success error code for a variety of reasons, not all of them fatal. Drop the efi_printk() now that we have more fine-grained, and more specific, error messages throughout the *setup_efi_pci*() code paths. Reported-by: Darren Hart <dvhart@...ux.intel.com> Reported-by: Josh Boyer <jwboyer@...oraproject.org> Cc: Ulf Winkelvos <ulf@...kelvos.de> Cc: Andre Müller <andre.muller@....de> Signed-off-by: Matt Fleming <matt.fleming@...el.com> --- This patch is based on top of Andre's ("x86/efi: Adding efi_printks on memory allocationa and pci.reads") sitting on the 'next' branch. arch/x86/boot/compressed/eboot.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c index ed8e06c59a4c..87398f9434f3 100644 --- a/arch/x86/boot/compressed/eboot.c +++ b/arch/x86/boot/compressed/eboot.c @@ -1394,10 +1394,7 @@ struct boot_params *efi_main(struct efi_config *c, setup_graphics(boot_params); - status = setup_efi_pci(boot_params); - if (status != EFI_SUCCESS) { - efi_printk(sys_table, "setup_efi_pci() failed!\n"); - } + setup_efi_pci(boot_params); status = efi_call_early(allocate_pool, EFI_LOADER_DATA, sizeof(*gdt), (void **)&gdt); -- 1.9.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists