linux-kernel - Re: [PATCH 1/8] arm: Convert pr_warning to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140915155656.GA29744@arm.com>
Date:	Mon, 15 Sep 2014 16:56:56 +0100
From:	Will Deacon <will.deacon@....com>
To:	Joe Perches <joe@...ches.com>
Cc:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Russell King <linux@....linux.org.uk>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/8] arm: Convert pr_warning to pr_warn

On Sat, Sep 13, 2014 at 07:31:12PM +0100, Joe Perches wrote:
> Use the more common pr_warn.
> 
> Other miscellanea:
> 
> o Coalesce formats
> o Realign arguments
> 
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  arch/arm/include/asm/syscall.h   |  8 ++++----
>  arch/arm/kernel/atags_parse.c    |  2 +-
>  arch/arm/kernel/hw_breakpoint.c  | 18 +++++++++---------
>  arch/arm/kernel/irq.c            |  4 ++--
>  arch/arm/kernel/perf_event_cpu.c |  4 ++--
>  arch/arm/kernel/smp.c            |  2 +-
>  arch/arm/kernel/unwind.c         | 24 ++++++++++++------------
>  arch/arm/mm/idmap.c              |  2 +-
>  arch/arm/mm/mmu.c                |  4 ++--
>  9 files changed, 34 insertions(+), 34 deletions(-)

It's Russell's call on this, but it really looks like more trouble than it's
worth imo. Having git blame identify the person who wrote the original code
is considerably more useful than being pointed at somebody making cosmetic
changes.

Will
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/