lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 15 Sep 2014 12:16:21 -0400 From: Jon Masters <jcm@...hat.com> To: Catalin Marinas <catalin.marinas@....com>, Hanjun Guo <hanjun.guo@...aro.org> CC: "Rafael J. Wysocki" <rjw@...ysocki.net>, Mark Rutland <Mark.Rutland@....com>, Olof Johansson <olof@...om.net>, "grant.likely@...aro.org" <grant.likely@...aro.org>, Will Deacon <Will.Deacon@....com>, "graeme.gregory@...aro.org" <graeme.gregory@...aro.org>, Arnd Bergmann <arnd@...db.de>, Sudeep Holla <Sudeep.Holla@....com>, "jcm@...hat.com" <jcm@...hat.com>, Jason Cooper <jason@...edaemon.net>, Marc Zyngier <Marc.Zyngier@....com>, Bjorn Helgaas <bhelgaas@...gle.com>, Daniel Lezcano <daniel.lezcano@...aro.org>, Mark Brown <broonie@...nel.org>, Rob Herring <robh@...nel.org>, Robert Richter <rric@...nel.org>, Lv Zheng <lv.zheng@...el.com>, Robert Moore <robert.moore@...el.com>, Lorenzo Pieralisi <Lorenzo.Pieralisi@....com>, Liviu Dudau <Liviu.Dudau@....com>, Randy Dunlap <rdunlap@...radead.org>, Charles Garcia-Tobin <Charles.Garcia-Tobin@....com>, "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v4 14/18] ARM64 / ACPI: Add GICv2 specific ACPI boot support On 09/15/2014 11:01 AM, Catalin Marinas wrote: > On Fri, Sep 12, 2014 at 03:00:12PM +0100, Hanjun Guo wrote: >> diff --git a/arch/arm64/kernel/acpi.c b/arch/arm64/kernel/acpi.c >> index 5b3546b..9869377 100644 >> --- a/arch/arm64/kernel/acpi.c >> +++ b/arch/arm64/kernel/acpi.c >> @@ -23,6 +23,7 @@ >> #include <linux/irqdomain.h> >> #include <linux/bootmem.h> >> #include <linux/smp.h> >> +#include <linux/irqchip/arm-gic-acpi.h> >> >> #include <asm/cputype.h> >> #include <asm/cpu_ops.h> >> @@ -312,6 +313,28 @@ void __init acpi_boot_table_init(void) >> pr_err("Can't find FADT or error happened during parsing FADT\n"); >> } >> >> +void __init acpi_gic_init(void) >> +{ >> + struct acpi_table_header *table; >> + acpi_status status; >> + acpi_size tbl_size; >> + int err; >> + >> + status = acpi_get_table_with_size(ACPI_SIG_MADT, 0, &table, &tbl_size); >> + if (ACPI_FAILURE(status)) { >> + const char *msg = acpi_format_exception(status); >> + >> + pr_err("Failed to get MADT table, %s\n", msg); >> + return; >> + } >> + >> + err = gic_v2_acpi_init(table); >> + if (err) >> + pr_err("Failed to initialize GIC IRQ controller"); >> + >> + early_acpi_os_unmap_memory((char *)table, tbl_size); >> +} > > Maybe this was discussed already but why does this function need to live > under arch/arm64? Isn't the driver code more appropriate? Well there's two halves to this, right? There's the MADT parsing/setup, which is architecture specific, and then there's the GIC irqchip initialization which lives under drivers. Jon. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists