linux-kernel - Re: [PATCH] netdev: octeon_mgmt: Fix ISO C90 forbids mixed declarations and code warning.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5417149D.2070301@caviumnetworks.com>
Date:	Mon, 15 Sep 2014 09:32:29 -0700
From:	David Daney <ddaney@...iumnetworks.com>
To:	David Daney <ddaney.cavm@...il.com>
CC:	<netdev@...r.kernel.org>, "David S. Miller" <davem@...emloft.net>,
	<linux-kernel@...r.kernel.org>, <linux-mips@...ux-mips.org>,
	David Daney <david.daney@...ium.com>,
	Heinrich Schuchardt <xypron.glpk@....de>,
	Joe Perches <joe@...ches.com>
Subject: Re: [PATCH] netdev: octeon_mgmt: Fix ISO C90 forbids mixed declarations
 and code warning.

On 09/15/2014 09:23 AM, David Daney wrote:
> From: David Daney <david.daney@...ium.com>
>
> We were getting:
>
>    drivers/net/ethernet/octeon/octeon_mgmt.c:295:4: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
>
> The idea of the fix from Joe Perches.
>
> Signed-off-by: David Daney <david.daney@...ium.com>
> Cc: Heinrich Schuchardt <xypron.glpk@....de>
> Cc: Joe Perches <joe@...ches.com>

Actually Aaro Koskinen's similar patch was just committed to the net.git 
tree (commit	208f7ca4d4a6886256763c9c073775c5fdaf47eb), so this whole 
thing seems to have been an exercise in time wasting.

I don't really care which patch goes in at this point.  So I defer to 
davem et al.

David Daney


> ---
>
> This patch should supersede previous patches from Heinrich Schuchardt,
> and may be preferable as it touches fewer lines of code.
>
>   drivers/net/ethernet/octeon/octeon_mgmt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/octeon/octeon_mgmt.c b/drivers/net/ethernet/octeon/octeon_mgmt.c
> index 979c698..5e10c1d 100644
> --- a/drivers/net/ethernet/octeon/octeon_mgmt.c
> +++ b/drivers/net/ethernet/octeon/octeon_mgmt.c
> @@ -290,12 +290,12 @@ static void octeon_mgmt_clean_tx_buffers(struct octeon_mgmt *p)
>   		/* Read the hardware TX timestamp if one was recorded */
>   		if (unlikely(re.s.tstamp)) {
>   			struct skb_shared_hwtstamps ts;
> -			memset(&ts, 0, sizeof(ts));
>   			/* Read the timestamp */
>   			u64 ns = cvmx_read_csr(CVMX_MIXX_TSTAMP(p->port));
>   			/* Remove the timestamp from the FIFO */
>   			cvmx_write_csr(CVMX_MIXX_TSCTL(p->port), 0);
>   			/* Tell the kernel about the timestamp */
> +			memset(&ts, 0, sizeof(ts));
>   			ts.hwtstamp = ns_to_ktime(ns);
>   			skb_tstamp_tx(skb, &ts);
>   		}
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/