linux-kernel - RE: [PATCH 0/4] staging: comedi: addi_apci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DC148C5AA1CEBA4E87973D432B1C2D8825FA1A20@P3PWEX4MB008.ex4.secureserver.net>
Date:	Mon, 15 Sep 2014 17:44:29 +0000
From:	Hartley Sweeten <HartleyS@...ionengravers.com>
To:	Ian Abbott <abbotti@....co.uk>,
	"driverdev-devel@...uxdriverproject.org" 
	<driverdev-devel@...uxdriverproject.org>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 0/4] staging: comedi: addi_apci_3120: redo DMA buffer
 allocation

On Friday, September 12, 2014 4:20 AM, Ian Abbott wrote:
> "addi_apci_3120" allocates more pages of DMA buffer than it uses, may
> allocate half a double-buffer it does not use because it's the "wrong"
> half that it managed to allocate (unlikely), and relies on virt_to_bus()
> to treat generic kernel memory from get_free_pages() as coherent DMA
> memory.  Correct the issues, using dma_alloc_coherent() to allocate the
> DMA buffers.
>
> 1) staging: comedi: addi_apci_3120: don't allocate 2nd DMA buffer on failure
> 2) staging: comedi: addi_apci_3120: don't overallocate DMA buffer
> 3) staging: comedi: addi_apci_3120: use dma_alloc_coherent()
> 4) staging: comedi: addi_apci_3120: simplify setting of devpriv->us_UseDma
>
>  drivers/staging/comedi/Kconfig                     |  2 +-
>  .../staging/comedi/drivers/addi-data/addi_common.h |  3 +-
>  drivers/staging/comedi/drivers/addi_apci_3120.c    | 44 ++++++++++------------
>  3 files changed, 22 insertions(+), 27 deletions(-)

Reviewed-by: H Hartley Sweeten <hsweeten@...ionengravers.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/