linux-kernel - Re: [PATCH 03/13] eeepc-laptop: coding style: add curly braces around else compound

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 15 Sep 2014 12:41:41 -0700
From:	Darren Hart <dvhart@...radead.org>
To:	Frans Klaver <fransklaver@...il.com>
Cc:	Corentin Chary <corentin.chary@...il.com>,
	Rafael Wysocki <rafael.j.wysocki@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	acpi4asus-user@...ts.sourceforge.net,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/13] eeepc-laptop: coding style: add curly braces
 around else compound

On Sat, Sep 13, 2014 at 01:06:42AM +0200, Frans Klaver wrote:
> Signed-off-by: Frans Klaver <fransklaver@...il.com>

Hi Frans,

Please merge the 3 coding style fixes into one patch. There is no functional
change here, and each of the 3 is obvious. Please include a simple commit
message to the effect of:

"
eeepc-laptop: Coding style cleanup

Correct white space and brace usage per Documentation/CodingStyle.
"

As a point of policy, I will not merge commits without a message, no matter how
trivial.

Thanks,

> ---
>  drivers/platform/x86/eeepc-laptop.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/eeepc-laptop.c b/drivers/platform/x86/eeepc-laptop.c
> index 702fcbb..9d8dff9 100644
> --- a/drivers/platform/x86/eeepc-laptop.c
> +++ b/drivers/platform/x86/eeepc-laptop.c
> @@ -1425,8 +1425,9 @@ static int eeepc_acpi_add(struct acpi_device *device)
>  		result = eeepc_backlight_init(eeepc);
>  		if (result)
>  			goto fail_backlight;
> -	} else
> +	} else {
>  		pr_info("Backlight controlled by ACPI video driver\n");
> +	}
>  
>  	result = eeepc_input_init(eeepc);
>  	if (result)
> -- 
> 2.1.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/