linux-kernel - Re: [PATCH] perf symbols: Add path to Ubuntu kernel debuginfo file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 15 Sep 2014 16:57:02 -0300
From:	Arnaldo Carvalho de Melo <acme@...hat.com>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Anton Blanchard <anton@...ba.org>, a.p.zijlstra@...llo.nl,
	paulus@...ba.org, mingo@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf symbols: Add path to Ubuntu kernel debuginfo file

Em Fri, Sep 12, 2014 at 03:43:28PM +0900, Namhyung Kim escreveu:
> On Tue, 9 Sep 2014 09:11:52 +1000, Anton Blanchard wrote:
> > Ubuntu places the kernel debuginfo in /usr/lib/debug/boot/vmlinux-*
> >
> > Signed-off-by: Anton Blanchard <anton@...ba.org>
> 
> It seems that you need to rebase it onto current acme/perf/core as
> there're little change in this area.  The patch itself looks good to me.

I updated the patch, to make it use the kernel_version from the
perf.data file if present, else it uses uts.release as in Anton's patch,
ok?

- Arnaldo
 
> Thanks,
> Namhyung
> 
> 
> > ---
> >
> > Index: b/tools/perf/util/symbol.c
> > ===================================================================
> > --- a/tools/perf/util/symbol.c
> > +++ b/tools/perf/util/symbol.c
> > @@ -1750,7 +1750,7 @@ static int vmlinux_path__init(void)
> >  	struct utsname uts;
> >  	char bf[PATH_MAX];
> >  
> > -	vmlinux_path = malloc(sizeof(char *) * 5);
> > +	vmlinux_path = malloc(sizeof(char *) * 6);
> >  	if (vmlinux_path == NULL)
> >  		return -1;
> >  
> > @@ -1784,6 +1784,12 @@ static int vmlinux_path__init(void)
> >  		 uts.release);
> >  	vmlinux_path[vmlinux_path__nr_entries] = strdup(bf);
> >  	if (vmlinux_path[vmlinux_path__nr_entries] == NULL)
> > +		goto out_fail;
> > +	++vmlinux_path__nr_entries;
> > +	snprintf(bf, sizeof(bf), "/usr/lib/debug/boot/vmlinux-%s",
> > +		 uts.release);
> > +	vmlinux_path[vmlinux_path__nr_entries] = strdup(bf);
> > +	if (vmlinux_path[vmlinux_path__nr_entries] == NULL)
> >  		goto out_fail;
> >  	++vmlinux_path__nr_entries;
> >  
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/