[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20140915213525.GA13468@core.coreip.homeip.net>
Date: Mon, 15 Sep 2014 14:35:26 -0700
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Nishanth Menon <nm@...com>
Cc: Jim Davis <jim.epost@...il.com>, linux-kernel@...r.kernel.org,
linux-input@...r.kernel.org, linux-omap@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH] Input: palmas-pwrbutton: Fix typo in License
On Mon, Sep 15, 2014 at 01:00:44PM -0500, Nishanth Menon wrote:
> On 09/15/2014 12:58 PM, Nishanth Menon wrote:
> > Follow the license string convention indicated in include/linux/module.h
> > (don't capitalize v).
> >
> > This fixes following randconfig warning:
> > FATAL: modpost: GPL-incompatible module palmas-pwrbutton.ko uses GPL-only symbol 'platform_driver_unregister'
> >
> Uggh.. forgot to add:
>
> Fixes: adff5962fdd2 ("Input: introduce palmas-pwrbutton")
Applied both, thank you.
>
> > Cc: Stephen Rothwell <sfr@...b.auug.org.au>
> > Reported-by: Jim Davis <jim.epost@...il.com>
> > Signed-off-by: Nishanth Menon <nm@...com>
> > ---
> > Reported thread http://marc.info/?l=linux-input&m=141080223209150&w=2
> >
> > drivers/input/misc/palmas-pwrbutton.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/input/misc/palmas-pwrbutton.c b/drivers/input/misc/palmas-pwrbutton.c
> > index 3f90211..4ed6f78 100644
> > --- a/drivers/input/misc/palmas-pwrbutton.c
> > +++ b/drivers/input/misc/palmas-pwrbutton.c
> > @@ -326,5 +326,5 @@ module_platform_driver(palmas_pwron_driver);
> >
> > MODULE_ALIAS("platform:palmas-pwrbutton");
> > MODULE_DESCRIPTION("Palmas Power Button");
> > -MODULE_LICENSE("GPL V2");
> > +MODULE_LICENSE("GPL v2");
> > MODULE_AUTHOR("Texas Instruments Inc.");
> >
>
> --
> Regards,
> Nishanth Menon
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists