linux-kernel - Re: [PATCH 11/13] eeepc-laptop: propagate errors from get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140915215050.GC64909@vmdeb7>
Date:	Mon, 15 Sep 2014 14:50:50 -0700
From:	Darren Hart <dvhart@...radead.org>
To:	Frans Klaver <fransklaver@...il.com>
Cc:	Corentin Chary <corentin.chary@...il.com>,
	Rafael Wysocki <rafael.j.wysocki@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	acpi4asus-user@...ts.sourceforge.net,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 11/13] eeepc-laptop: propagate errors from get_cpufv

On Sat, Sep 13, 2014 at 01:06:50AM +0200, Frans Klaver wrote:
> In show_available_cpufv, show_cpufv, and store_cpufv, errors from
> get_cpufv are mapped to -ENODEV. To paint a clear picture to callers,
> propagate the errors instead.
> 

Ooops, should have forwarded this one around instead. I generally agree with
this approach, but do want confirmation from Greg and others that this is
an acceptable change to the sysfs interface.

--
Darren

> Signed-off-by: Frans Klaver <fransklaver@...il.com>
> ---
>  drivers/platform/x86/eeepc-laptop.c | 16 ++++++++++------
>  1 file changed, 10 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/platform/x86/eeepc-laptop.c b/drivers/platform/x86/eeepc-laptop.c
> index 828db56..732b012 100644
> --- a/drivers/platform/x86/eeepc-laptop.c
> +++ b/drivers/platform/x86/eeepc-laptop.c
> @@ -351,8 +351,9 @@ static ssize_t show_available_cpufv(struct device *dev,
>  	int i;
>  	ssize_t len = 0;
>  
> -	if (get_cpufv(eeepc, &c))
> -		return -ENODEV;
> +	i = get_cpufv(eeepc, &c);
> +	if (i)
> +		return i;
>  	for (i = 0; i < c.num; i++)
>  		len += sprintf(buf + len, "%d ", i);
>  	len += sprintf(buf + len, "\n");
> @@ -365,9 +366,11 @@ static ssize_t show_cpufv(struct device *dev,
>  {
>  	struct eeepc_laptop *eeepc = dev_get_drvdata(dev);
>  	struct eeepc_cpufv c;
> +	int rv;
>  
> -	if (get_cpufv(eeepc, &c))
> -		return -ENODEV;
> +	rv = get_cpufv(eeepc, &c);
> +	if (rv)
> +		return rv;
>  	return sprintf(buf, "%#x\n", (c.num << 8) | c.cur);
>  }
>  
> @@ -381,8 +384,9 @@ static ssize_t store_cpufv(struct device *dev,
>  
>  	if (eeepc->cpufv_disabled)
>  		return -EPERM;
> -	if (get_cpufv(eeepc, &c))
> -		return -ENODEV;
> +	rv = get_cpufv(eeepc, &c);
> +	if (rv)
> +		return rv;
>  	rv = parse_arg(buf, &value);
>  	if (rv < 0)
>  		return rv;
> -- 
> 2.1.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/