linux-kernel - Re: [PATCH] staging: dgap: use schedule_timeout_interruptible() instead of dgap_ms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHb8M2DN+FyctZVeQjR5jOQ=GPUYVDCAy2f_Q145TPU2Cg0dTg@mail.gmail.com>
Date:	Tue, 16 Sep 2014 16:16:42 +0900
From:	DaeSeok Youn <daeseok.youn@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Lidza Louina <lidza.louina@...il.com>,
	Mark Hounschell <markh@...pro.net>,
	devel <devel@...verdev.osuosl.org>,
	Greg KH <gregkh@...uxfoundation.org>,
	driverdev-devel@...uxdriverproject.org,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: dgap: use schedule_timeout_interruptible()
 instead of dgap_ms_sleep()

Hi,

2014-09-16 15:31 GMT+09:00 Dan Carpenter <dan.carpenter@...cle.com>:
>
> On Tue, Sep 16, 2014 at 12:33:33PM +0900, Daeseok Youn wrote:
> > @@ -2297,12 +2273,12 @@ static void dgap_tty_close(struct tty_struct *tty, struct file *file)
> >                        * Go to sleep to ensure RTS/DTR
> >                        * have been dropped for modems to see it.
> >                        */
> > -                     if (ch->ch_close_delay) {
> > -                             spin_unlock_irqrestore(&ch->ch_lock,
> > -                                                    lock_flags);
> > -                             dgap_ms_sleep(ch->ch_close_delay);
> > -                             spin_lock_irqsave(&ch->ch_lock, lock_flags);
> > -                     }
> > +                     spin_unlock_irqrestore(&ch->ch_lock,
> > +                                     lock_flags);
> > +                     /* .25 second delay for dropping RTS/DTR */
> > +                     schedule_timeout_interruptible(msecs_to_jiffies(250));
> > +                     signal_pending(current);
>
> There is no point in calling signal_pending() if you don't care about
> the return value.
Yes, you're right.
Originally it didn't have any handling of the return value from
signal_pending().
So, I will re-send this patch after removing signal_pending().

Thanks.

regards,
Daeseok Youn
>
> > +                     spin_lock_irqsave(&ch->ch_lock, lock_flags);
> >               }
> >
>
> regards,
> dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/