lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 16 Sep 2014 15:00:29 +0800 From: Jiang Liu <jiang.liu@...ux.intel.com> To: Yijing Wang <wangyijing@...wei.com>, Joerg Roedel <joro@...tes.org>, David Woodhouse <dwmw2@...radead.org>, Yinghai Lu <yinghai@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>, Dan Williams <dan.j.williams@...el.com>, Vinod Koul <vinod.koul@...el.com>, "Rafael J . Wysocki" <rafael.j.wysocki@...el.com> CC: Ashok Raj <ashok.raj@...el.com>, Tony Luck <tony.luck@...el.com>, iommu@...ts.linux-foundation.org, linux-pci@...r.kernel.org, linux-hotplug@...r.kernel.org, linux-kernel@...r.kernel.org, dmaengine@...r.kernel.org Subject: Re: [Patch Part3 V5 5/8] iommu/vt-d: Enhance intel_irq_remapping driver to support DMAR unit hotplug On 2014/9/15 10:20, Yijing Wang wrote: >> +static void ir_remove_ioapic_hpet_scope(struct intel_iommu *iommu) >> +{ >> + int i; >> >> - ir_parse_one_hpet_scope(scope, iommu); >> - } >> - start += scope->length; >> - } >> + for (i = 0; i < MAX_HPET_TBS; i++) >> + if (ir_hpet[i].iommu == iommu) >> + ir_hpet[i].iommu = NULL; > > Hi Gerry, why not reset whole ir_hpe and ir_ioapic data struct? Hi Yijing, Thanks for review. Zero is legal for id, bus and devfn in struct ioapic_scope and struct hpet_scope. So we use domain field as a flag to mark entry valid or invalid and only reset iommu field. Regards! Gerry > > > >> >> - return 0; >> + for (i = 0; i < MAX_IO_APICS; i++) >> + if (ir_ioapic[i].iommu == iommu) >> + ir_ioapic[i].iommu = NULL; >> } >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists