linux-kernel - Re: [PATCH] x86/vdso: use NULL instead of zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140916083618.GA1712@gmail.com>
Date:	Tue, 16 Sep 2014 10:36:18 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Michele Curti <michele.curti@...il.com>
Cc:	x86@...nel.org, tglx@...utronix.de, mingo@...hat.com,
	hpa@...or.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/vdso: use NULL instead of zero


* Michele Curti <michele.curti@...il.com> wrote:

> 
> x86/vdso: use NULL instead of zero in patch_vdso32()
> 
> Signed-off-by: Michele Curti <michele.curti@...il.com>
> 
> diff --git a/arch/x86/vdso/vma.c b/arch/x86/vdso/vma.c
> index 1ad1026..a4647bc 100644
> --- a/arch/x86/vdso/vma.c
> +++ b/arch/x86/vdso/vma.c
> @@ -34,7 +34,7 @@ static unsigned vdsox32_size;
>  void __init patch_vdso32(void *vdso, size_t len)
>  {
>  	Elf32_Ehdr *hdr = vdso;
> -	Elf32_Shdr *sechdrs, *alt_sec = 0;
> +	Elf32_Shdr *sechdrs, *alt_sec = NULL;
>  	char *secstrings;
>  	void *alt_data;
>  	int i;

Your patch does not apply, this code got significantly reworked 
in the following commit, earlier this year:

  6f121e548f83 x86, vdso: Reimplement vdso.so preparation in build-time C

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/