lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-id: <1410857494-15936-1-git-send-email-k.kozlowski@samsung.com> Date: Tue, 16 Sep 2014 10:51:30 +0200 From: Krzysztof Kozlowski <k.kozlowski@...sung.com> To: Russell King <linux@....linux.org.uk>, Dan Williams <dan.j.williams@...el.com>, Vinod Koul <vinod.koul@...el.com>, linux-kernel@...r.kernel.org, dmaengine@...r.kernel.org, Ulf Hansson <ulf.hansson@...aro.org>, Grant Likely <grant.likely@...aro.org>, Lars-Peter Clausen <lars@...afoo.de>, Michal Simek <michal.simek@...inx.com>, "Rafael J. Wysocki" <rjw@...ysocki.net>, Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>, Randy Dunlap <rdunlap@...radead.org>, Alan Stern <stern@...land.harvard.edu>, linux-doc@...r.kernel.org, linux-pm@...r.kernel.org Cc: Kyungmin Park <kyungmin.park@...sung.com>, Marek Szyprowski <m.szyprowski@...sung.com>, Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>, Krzysztof Kozlowski <k.kozlowski@...sung.com> Subject: [PATCH v4 0/4] amba/dma: pl330: add Power Management support Hi, This is fourth version of patches adding runtime PM to the pl330 driver. The runtime PM of pl330 driver requires interrupt safe suspend/resume callbacks which is in conflict with current amba bus driver. The latter also unprepares and prepares the AMBA bus clock which is not safe for atomic context. The patchset solves this in patch 3/4 by handling clocks in different way if device driver set interrupt safe runtime PM. Any comments are welcome. Tested on boards with pl330 DMA driver: - Trats2 (Exynos4212) - Samsung Gear2-like development board (Exynos3250) TODO/ideas: =========== Consider renaming existing pm_runtime_irq_safe() function to keep up with naming convention after adding pm_runtime_is_irq_safe() in patch 1/4. This naming: - pm_runtime_irq_safe() as setter, - pm_runtime_is_irq_safe() as getter, is contradictory to naming of other PM runtime functions, e.g.: - pm_runtime_set_active() as setter, - pm_runtime_active() as getter. I didn't change the naming of pm_runtime_irq_safe() because I wanted to minimize the impact of the patches. Changes since v3: ================= 1. Patch 1/4: Document new API in Documentation/power/runtime_pm.txt (pointed by Alan Stern). Changes since v2: ================= 1. Add patch 1 (PM / Runtime: Add getter for quering the IRQ safe option) 2. Add patch 2 (amba: Add helper macros for (un)preparing AMBA clock) 3. Patch 3/4: Rewrite the idea. If IRQ safe runtime PM is set then do not unprepare/prepare the clocks. Suggested by Russell King. 4. Patch 4/4: During system sleep unprepare the clock. Changes since v1: ================= 1. Add patch 1 (amba: Allow AMBA drivers to use their own runtime PM). 2. Patch 2/2: Apply Michal Simek's suggestions. 3. Patch 2/2: Fix atomic context safeness in pl330_issue_pending(). Best regards, Krzysztof Kozlowski Krzysztof Kozlowski (4): PM / Runtime: Add getter for quering the IRQ safe option amba: Add helper macros for (un)preparing AMBA clock amba: Don't unprepare the clocks if device driver wants IRQ safe runtime PM dma: pl330: add Power Management support Documentation/power/runtime_pm.txt | 4 ++ drivers/amba/bus.c | 30 +++++++++++++-- drivers/dma/pl330.c | 77 ++++++++++++++++++++++++++++++++++++-- include/linux/amba/bus.h | 7 ++++ include/linux/pm_runtime.h | 6 +++ 5 files changed, 116 insertions(+), 8 deletions(-) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists