lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 16 Sep 2014 11:34:55 +0200 From: Krzysztof Kozlowski <k.kozlowski@...sung.com> To: Russell King - ARM Linux <linux@....linux.org.uk> Cc: Dan Williams <dan.j.williams@...el.com>, Vinod Koul <vinod.koul@...el.com>, linux-kernel@...r.kernel.org, dmaengine@...r.kernel.org, Ulf Hansson <ulf.hansson@...aro.org>, Grant Likely <grant.likely@...aro.org>, Lars-Peter Clausen <lars@...afoo.de>, Michal Simek <michal.simek@...inx.com>, "Rafael J. Wysocki" <rjw@...ysocki.net>, Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>, Randy Dunlap <rdunlap@...radead.org>, Alan Stern <stern@...land.harvard.edu>, linux-doc@...r.kernel.org, linux-pm@...r.kernel.org, Kyungmin Park <kyungmin.park@...sung.com>, Marek Szyprowski <m.szyprowski@...sung.com>, Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com> Subject: Re: [PATCH v4 3/4] amba: Don't unprepare the clocks if device driver wants IRQ safe runtime PM On wto, 2014-09-16 at 10:20 +0100, Russell King - ARM Linux wrote: > On Tue, Sep 16, 2014 at 10:51:33AM +0200, Krzysztof Kozlowski wrote: > > @@ -191,8 +210,11 @@ static int amba_probe(struct device *dev) > > pm_runtime_enable(dev); > > > > ret = pcdrv->probe(pcdev, id); > > - if (ret == 0) > > + if (ret == 0) { > > + if (pm_runtime_is_irq_safe(dev)) > > + pcdev->irq_safe = 1; > > Patch looks good, though I'd prefer this to always explicitly initialise > pcdev->irq_safe each time a probe succeeds. No problem, I'll add this and resend. Thank you for feedback, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists