linux-kernel - Re: [PATCH] arch/microblaze/kernel/setup.c: Add default 'screen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdWnZVi9rXzmOxsuwMeUcCvW_CH0bi_KuYiCNcp3JQHhLA@mail.gmail.com>
Date:	Tue, 16 Sep 2014 12:04:57 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Michal Simek <monstr@...str.eu>
Cc:	Chen Gang <gang.chen.5i5j@...il.com>,
	Rob Herring <rob.herring@...xeda.com>,
	Paul Bolle <pebolle@...cali.nl>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Mikael Starvik <starvik@...s.com>,
	Jesper Nilsson <jesper.nilsson@...s.com>
Subject: Re: [PATCH] arch/microblaze/kernel/setup.c: Add default 'screen_info"
 for fixing compiling break

Hi Michal,

On Tue, Sep 16, 2014 at 11:23 AM, Michal Simek <monstr@...str.eu> wrote:
> On 09/14/2014 11:02 AM, Chen Gang wrote:
>> On 09/14/2014 04:45 PM, Geert Uytterhoeven wrote:
>>> Hi Chen,
>>>
>>> On Sun, Sep 14, 2014 at 10:32 AM, Chen Gang <gang.chen.5i5j@...il.com> wrote:
>>>> Add default one just like other architectures have done (e.g. cris,
>>>> score, sh ...), the related error with allmodconfig:
>>>>
>>>>     LD      init/built-in.o
>>>>   drivers/built-in.o: In function `vgacon_save_screen':
>>>>   drivers/video/console/.tmp_vgacon.o:(.text+0x834d0): undefined reference to `screen_info'
>>>>   drivers/video/console/.tmp_vgacon.o:(.text+0x834ec): undefined reference to `screen_info'
>>>>   drivers/built-in.o: In function `vgacon_resize':
>>>>   drivers/video/console/.tmp_vgacon.o:(.text+0x83cdc): undefined reference to `screen_info'
>>>>   drivers/video/console/.tmp_vgacon.o:(.text+0x83d38): undefined reference to `screen_info'
>>>>   drivers/built-in.o: In function `vgacon_switch':
>>>>   drivers/video/console/.tmp_vgacon.o:(.text+0x83f50): undefined reference to `screen_info'
>>>>   drivers/built-in.o:drivers/video/console/.tmp_vgacon.o:(.text+0x8407c): more undefined references to `screen_info' follow
>>>>   make: *** [vmlinux] Error 1
>>>
>>> Can microblaze actually have VGA?
>>>
>>> If not, it's better to disable it.
>>>
>>
>> Welcome the related microblaze maintainers ideas for it
>
> Is this is just about VGA or video console in general?
> There is xilinx FB driver and other FB are around too.

These days screen_info is only used by:
  - vgacon,
  - dummycon on ARM,
  - a few fb drivers (efifb, intelfbdrv,sis, vesafb, and vga16fb).

E.g. m68k doesn't have it.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/