lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 16 Sep 2014 15:48:02 +0200 From: Javier Martinez Canillas <javier@...hile0.org> To: Chanwoo Choi <cw00.choi@...sung.com> Cc: Alessandro Zummo <a.zummo@...ertech.it>, Kukjin Kim <kgene.kim@...sung.com>, akpm@...ux-foundation.org, Kyungmin Park <kyungmin.park@...sung.com>, rtc-linux@...glegroups.com, Linux Kernel <linux-kernel@...r.kernel.org>, "linux-samsung-soc@...r.kernel.org" <linux-samsung-soc@...r.kernel.org> Subject: Re: [PATCHv3 4/5] rtc: s3c: Add support for RTC of Exynos3250 SoC Hello Chanwoo, On Thu, Aug 28, 2014 at 11:02 AM, Chanwoo Choi <cw00.choi@...sung.com> wrote: > This patch add support for RTC of Exynos3250 SoC. The Exynos3250 needs source > clock(32.768KHz) for RTC block. If source clock of RTC is registerd on clock > list of common clk framework, Exynos RTC drvier have to control this clock. > > Clock list for s3c-rtc device: > - rtc : CLK_RTC of CLK_GATE_IP_PERIR is gate clock for RTC. > - rtc_src : XrtcXTI is 32.768.kHz source clock for RTC. Is this RTC source clock needed for all Exynos SoCs? > @@ -480,11 +530,19 @@ static int s3c_rtc_probe(struct platform_device *pdev) > > info->rtc_clk = devm_clk_get(&pdev->dev, "rtc"); > if (IS_ERR(info->rtc_clk)) { > - dev_err(&pdev->dev, "failed to find rtc clock source\n"); > + dev_err(&pdev->dev, "failed to find rtc clock\n"); > return PTR_ERR(info->rtc_clk); > } > clk_prepare_enable(info->rtc_clk); > > + info->rtc_src_clk = devm_clk_get(&pdev->dev, "rtc_src"); > + if (IS_ERR(info->rtc_src_clk)) { > + dev_err(&pdev->dev, "failed to find rtc source clock\n"); > + return PTR_ERR(info->rtc_src_clk); On an Exynos5420 Peach Pit machine I'm having the following error and the driver fails to probe: [ 2.095700] s3c-rtc: probe of 101e0000.rtc failed with error -2 Reverting this patch fixes the issue and the s3c RTC works again on this machine. Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists