linux-kernel - Re: [PATCH] PM: Add helper to mark last busy and autosuspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1409161024580.1166-100000@iolanthe.rowland.org>
Date:	Tue, 16 Sep 2014 10:27:53 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	"Subhransu S. Prusty" <subhransu.s.prusty@...el.com>
cc:	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Ulf Hansson <ulf.hansson@...aro.org>,
	<linux-kernel@...r.kernel.org>, <vinod.koul@...el.com>
Subject: Re: [PATCH] PM: Add helper to mark last busy and autosuspend

On Tue, 16 Sep 2014, Subhransu S. Prusty wrote:

> pm_runtime_mark_last_busy and pm_runtime_put_autosuspend are used together
> in quite a lot of places. Add a helper for these.
> 
> Signed-off-by: Subhransu S. Prusty <subhransu.s.prusty@...el.com>
> ---
>  include/linux/pm_runtime.h | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/include/linux/pm_runtime.h b/include/linux/pm_runtime.h
> index 367f49b..256ec50 100644
> --- a/include/linux/pm_runtime.h
> +++ b/include/linux/pm_runtime.h
> @@ -277,4 +277,10 @@ static inline void pm_runtime_dont_use_autosuspend(struct device *dev)
>  	__pm_runtime_use_autosuspend(dev, false);
>  }
>  
> +static inline int pm_runtime_last_busy_and_autosuspend(struct device *dev)
> +{
> +	pm_runtime_mark_last_busy(dev);
> +	return pm_runtime_put_autosuspend(dev);
> +}
> +
>  #endif

What's the advantage?  Removing a few bytes of source code?  There will 
no change to the object code.  (Not to mention that your patch didn't 
actually change _any_ of the places where both routines get called!)

Besides, if you're going to make an addition to the runtime PM API like 
this, then you also have to update Documentation/power/runtime_pm.txt.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/