linux-kernel - Re: [PATCH] x86/pmc_atom: Fix warning when CONFIG_DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54184F88.60001@martingkelly.com>
Date:	Tue, 16 Sep 2014 07:56:08 -0700
From:	Martin Kelly <martin@...tingkelly.com>
To:	Ingo Molnar <mingo@...nel.org>
CC:	x86@...nel.org, vishwesh.m.rudramuni@...el.com, joe@...ches.com,
	hpa@...ux.intel.com, aubrey.li@...ux.intel.com,
	linux-kernel@...r.kernel.org, Martin Kelly <martkell@...zon.com>
Subject: Re: [PATCH] x86/pmc_atom: Fix warning when CONFIG_DEBUG_FS=n

On 09/15/2014 11:38 PM, Ingo Molnar wrote:
> 
> This uglifies the code which is bad. A nicer fix would be to 
> improve the code: for example define pmc_dbgfs_register() in the 
> !DEBUG_FS case as well, with a return 0 or so.
> 
> Thanks,
> 
> 	Ingo
> 

I like your suggestion and will issue a revision.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/