linux-kernel - Re: [PATCH 07/22] isofs: Replace strnicmp with strncasecmp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 16 Sep 2014 23:19:35 +0200
From:	Jan Kara <jack@...e.cz>
To:	Rasmus Villemoes <linux@...musvillemoes.dk>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Jan Kara <jack@...e.cz>
Subject: Re: [PATCH 07/22] isofs: Replace strnicmp with strncasecmp

On Tue 16-09-14 22:51:21, Rasmus Villemoes wrote:
> The kernel used to contain two functions for length-delimited,
> case-insensitive string comparison, strnicmp with correct semantics
> and a slightly buggy strncasecmp. The latter is the POSIX name, so
> strnicmp was renamed to strncasecmp, and strnicmp made into a wrapper
> for the new strncasecmp to avoid breaking existing users.
> 
> To allow the compat wrapper strnicmp to be removed at some point in
> the future, and to avoid the extra indirection cost, do
> s/strnicmp/strncasecmp/g.
> 
> Cc: Jan Kara <jack@...e.cz>
> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>
  Looks good.

  Reviewed-by: Jan Kara <jack@...e.cz>

								Honza
> ---
>  fs/isofs/inode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/isofs/inode.c b/fs/isofs/inode.c
> index 5ddaf86..881b3bd 100644
> --- a/fs/isofs/inode.c
> +++ b/fs/isofs/inode.c
> @@ -247,7 +247,7 @@ static int isofs_dentry_cmp_common(
>  	}
>  	if (alen == blen) {
>  		if (ci) {
> -			if (strnicmp(name->name, str, alen) == 0)
> +			if (strncasecmp(name->name, str, alen) == 0)
>  				return 0;
>  		} else {
>  			if (strncmp(name->name, str, alen) == 0)
> -- 
> 2.0.4
> 
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/