lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 16 Sep 2014 11:11:58 +0900 From: Masahiro Yamada <yamada.m@...panasonic.com> To: Brian Norris <computersforpeace@...il.com> Cc: linux-mtd@...ts.infradead.org, Rashika Kheria <rashika.kheria@...il.com>, linux-kernel@...r.kernel.org, Huang Shijie <shijie8@...il.com>, Jiri Kosina <trivial@...nel.org>, David Woodhouse <dwmw2@...radead.org>, "grmoore@...era.com" <grmoore@...era.com>, Josh Triplett <josh@...htriplett.org> Subject: Re: [PATCH v2 0/7] mtd: denali: A collection of trivial coding style fixes Hi Brian, On Mon, 15 Sep 2014 17:36:20 -0700 Brian Norris <computersforpeace@...il.com> wrote: > On Tue, Sep 09, 2014 at 11:01:50AM +0900, Masahiro Yamada wrote: > > Changes in v2: > > - Join quotes strings into a single line > > > > Masahiro Yamada (7): > > mtd: denali: fix the format of comment blocks > > mtd: denali: remove unnecessary variable initializations > > mtd: denali: remove unnecessary casts > > mtd: denali: change the type of iterators to int > > mtd: denali: remove a set-but-unused variable > > mtd: denali: remove unnecessary parentheses > > mtd: denali: fix indents and other trivial things > > > > drivers/mtd/nand/denali.c | 562 +++++++++++++++++++++++++--------------------- > > 1 file changed, 303 insertions(+), 259 deletions(-) > > Pushed patches 1 to 5 to l2-mtd.git. Thanks! > > Patch 6 has a conflict with another fix already in l2-mtd.git. Can you > rebase and resend? Sorry for my ignorance, but where can I find l2-mtd.git? In my understanding, the subsystem repositories should be documented in MAINTAINERS, so I looked for it but just found T: git git://git.infradead.org/linux-mtd.git. I do not think it is the one you mentioned. > BTW, my automatic build tests show that there's at least one other > 'unused' warning left, in case you want to tackle it too: > > drivers/mtd/nand/denali.c: In function ‘denali_read_page_raw’: > drivers/mtd/nand/denali.c:1221:11: warning: variable ‘irq_status’ set but not used [-Wunused-but-set-variable] > uint32_t irq_status; > You are right. (What is odd enough is this warning was not displayed on my build test. I do not know why.) Is there a chance for me to resend 5/7 to include this fix? Or is it too late? Best Regards Masahiro Yamada -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists