| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140916023922.GB2386@qualcomm.com>
Date: Mon, 15 Sep 2014 21:39:22 -0500
From: Andy Gross <agross@...eaurora.org>
To: Kiran Padwal <kiran.padwal@...rtplayin.com>
Cc: robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
davidb@...eaurora.org, afaerber@...e.de,
devicetree@...r.kernel.org, linux@....linux.org.uk,
linux-arm-kernel@...ts.infradead.org,
linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] ARM: apq8064: Add pinmux and i2c pinctrl nodes
On Tue, Aug 26, 2014 at 05:00:45PM +0530, Kiran Padwal wrote:
> This patch adds pinmux and i2c pinctrl DT node for IFC6410 board.
> It also adds necessary DT support for i2c eeprom which is present on
> IFC6410.
>
> Tested on IFC6410 board.
Looks fine
>
> Signed-off-by: Kiran Padwal <kiran.padwal@...rtplayin.com>
> ---
> Changes since v2:
> - Renamed pinmux i2c subnode "i2c1_pinmux" to "i2c1".
> - Removed labes of node.
> - Used canonical value as "okay" instead of "ok".
> - Used macros.
>
> Changes since v1:
> - Renamed pinmux phandle "qcom_pinmux" to "tlmm_pinmux".
> - Updated pinmux interrupt.
>
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 27 ++++++++++++++
> arch/arm/boot/dts/qcom-apq8064.dtsi | 53 ++++++++++++++++++++++++++++
> 2 files changed, 80 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
> index 7c2441d..ef0857e 100644
> --- a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
> +++ b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
> @@ -5,6 +5,24 @@
> compatible = "qcom,apq8064-ifc6410", "qcom,apq8064";
>
> soc {
> + gsbi@...40000 {
> + status = "okay";
> + qcom,mode = <GSBI_PROT_I2C>;
> +
> + i2c@...60000 {
> + status = "okay";
> + clock-frequency = <200000>;
> + pinctrl-0 = <&i2c1_pins>;
> + pinctrl-names = "default";
> +
> + eeprom: eeprom@52 {
> + compatible = "atmel,24c128";
> + reg = <0x52>;
> + pagesize = <32>;
> + };
don't need read only here. the eeprom is not being used by anything....
thankfully.
> + };
> + };
> +
> gsbi@...00000 {
> status = "ok";
> qcom,mode = <GSBI_PROT_I2C_UART>;
> @@ -12,5 +30,14 @@
> status = "ok";
> };
> };
> +
> + pinmux@...000 {
> + i2c1_pins: i2c1 {
> + mux {
> + pins = "gpio20", "gpio21";
> + function = "gsbi1";
> + };
> + };
> + };
> };
> };
> diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi
> index 92bf793..5dddbf3 100644
> --- a/arch/arm/boot/dts/qcom-apq8064.dtsi
> +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi
> @@ -89,6 +89,17 @@
> cpu-offset = <0x80000>;
> };
>
> + tlmm_pinmux: pinmux@...000 {
> + compatible = "qcom,apq8064-pinctrl";
> + reg = <0x800000 0x4000>;
> +
> + gpio-controller;
> + #gpio-cells = <2>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + interrupts = <0 16 IRQ_TYPE_LEVEL_HIGH>;
> + };
> +
> acc0: clock-controller@...8000 {
> compatible = "qcom,kpss-acc-v1";
> reg = <0x02088000 0x1000>, <0x02008000 0x1000>;
> @@ -133,6 +144,48 @@
> regulator;
> };
>
> + gsbi1: gsbi@...40000 {
> + status = "disabled";
> + compatible = "qcom,gsbi-v1.0.0";
> + reg = <0x12440000 0x100>;
> + clocks = <&gcc GSBI1_H_CLK>;
> + clock-names = "iface";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + i2c1: i2c@...60000 {
> + compatible = "qcom,i2c-qup-v1.1.1";
> + reg = <0x12460000 0x1000>;
> + interrupts = <0 194 IRQ_TYPE_NONE>;
> + clocks = <&gcc GSBI1_QUP_CLK>, <&gcc GSBI1_H_CLK>;
> + clock-names = "core", "iface";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };
> + };
> +
> + gsbi2: gsbi@...80000 {
> + status = "disabled";
> + compatible = "qcom,gsbi-v1.0.0";
> + reg = <0x12480000 0x100>;
> + clocks = <&gcc GSBI2_H_CLK>;
> + clock-names = "iface";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + i2c2: i2c@...a0000 {
> + compatible = "qcom,i2c-qup-v1.1.1";
> + reg = <0x124a0000 0x1000>;
> + interrupts = <0 196 IRQ_TYPE_NONE>;
> + clocks = <&gcc GSBI2_QUP_CLK>, <&gcc GSBI2_H_CLK>;
> + clock-names = "core", "iface";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };
> + };
> +
> gsbi7: gsbi@...00000 {
> status = "disabled";
> compatible = "qcom,gsbi-v1.0.0";
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists