linux-kernel - Re: [PATCH] extcon: sm5502: Drop useless include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-id: <32259363.443141410910688801.JavaMail.weblogic@epml01>
Date:	Tue, 16 Sep 2014 23:38:09 +0000 (GMT)
From:	함명주 <myungjoo.ham@...sung.com>
To:	Jean Delvare <jdelvare@...e.de>,
	최찬우 <cw00.choi@...sung.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] extcon: sm5502: Drop useless include

> Don't include <linux/input.h> when the driver does not use anything
> from this header file.
> 
> Signed-off-by: Jean Delvare <jdelvare@...e.de>
> Cc: Chanwoo Choi <cw00.choi@...sung.com>
> Cc: MyungJoo Ham <myungjoo.ham@...sung.com>

Acked-by: MyungJoo Ham <myungjoo.ham@...sung.com>

Chanwoo, please review/merge the patch when you return.

Cheers,
MyungJoo

> ---
>  drivers/extcon/extcon-sm5502.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> --- a/drivers/extcon/extcon-sm5502.c
> +++ b/drivers/extcon/extcon-sm5502.c
> @@ -17,7 +17,6 @@
>  
>  #include <linux/err.h>
>  #include <linux/i2c.h>
> -#include <linux/input.h>
>  #include <linux/interrupt.h>
>  #include <linux/irqdomain.h>
>  #include <linux/kernel.h>
> 
> -- 
> Jean Delvare
> SUSE L3 Support
> 
> 
>