linux-kernel - Re: [PATCH 08/22] ALSA: hda - Replace strnicmp with strncasecmp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 17 Sep 2014 07:54:22 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Rasmus Villemoes <linux@...musvillemoes.dk>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Jaroslav Kysela <perex@...ex.cz>,
	alsa-devel@...a-project.org
Subject: Re: [PATCH 08/22] ALSA: hda - Replace strnicmp with strncasecmp

At Tue, 16 Sep 2014 22:51:22 +0200,
Rasmus Villemoes wrote:
> 
> The kernel used to contain two functions for length-delimited,
> case-insensitive string comparison, strnicmp with correct semantics
> and a slightly buggy strncasecmp. The latter is the POSIX name, so
> strnicmp was renamed to strncasecmp, and strnicmp made into a wrapper
> for the new strncasecmp to avoid breaking existing users.
> 
> To allow the compat wrapper strnicmp to be removed at some point in
> the future, and to avoid the extra indirection cost, do
> s/strnicmp/strncasecmp/g.
> 
> Cc: Jaroslav Kysela <perex@...ex.cz>
> Cc: Takashi Iwai <tiwai@...e.de>
> Cc: alsa-devel@...a-project.org
> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>

Applied, thanks.


Takashi

> ---
>  sound/pci/hda/hda_sysfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/pci/hda/hda_sysfs.c b/sound/pci/hda/hda_sysfs.c
> index e207909..9b49f15 100644
> --- a/sound/pci/hda/hda_sysfs.c
> +++ b/sound/pci/hda/hda_sysfs.c
> @@ -514,7 +514,7 @@ enum {
>  
>  static inline int strmatch(const char *a, const char *b)
>  {
> -	return strnicmp(a, b, strlen(b)) == 0;
> +	return strncasecmp(a, b, strlen(b)) == 0;
>  }
>  
>  /* parse the contents after the line "[codec]"
> -- 
> 2.0.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/