linux-kernel - Re: [PATCH 1/1] staging: rtl8723au: fix sparse incorrect type assignment warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140917082627.GH17875@mwanda>
Date:	Wed, 17 Sep 2014 11:26:27 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Kieron Browne <kieron.browne@...il.com>
Cc:	Larry.Finger@...inger.net, Jes.Sorensen@...hat.com,
	gregkh@...uxfoundation.org, linux-wireless@...r.kernel.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] staging: rtl8723au: fix sparse incorrect type
 assignment warnings

On Tue, Sep 16, 2014 at 11:28:09PM +0100, Kieron Browne wrote:
> Use cpu_to_le16 to cast int for assignment to __le16 members
> 

"cast" is the wrong word.  It's really doing a byte swap.  It fixes a
bug on big endian systems.

But the patch is ok and matches how the other rtl drivers do it.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/