linux-kernel - Re: [PATCH] selftests/memfd: Run test on all architectures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 17 Sep 2014 14:28:00 +0200
From:	David Herrmann <dh.herrmann@...il.com>
To:	Pranith Kumar <bobby.prani@...il.com>
Cc:	Shuah Khan <shuahkh@....samsung.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Hugh Dickins <hughd@...gle.com>,
	Phong Tran <tranmanphong@...il.com>,
	"open list:KERNEL SELFTEST F..." <linux-api@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] selftests/memfd: Run test on all architectures

Hi

On Tue, Sep 16, 2014 at 12:59 AM, Pranith Kumar <bobby.prani@...il.com> wrote:
> Remove the dependence on x86 to run the memfd test. Verfied on 32-bit powerpc.
>
> Signed-off-by: Pranith Kumar <bobby.prani@...il.com>

Now that most archs have __NR_memfd_create, this is:

Reviewed-by: David Herrmann <dh.herrmann@...il.com>

Thanks
David

> ---
>  tools/testing/selftests/memfd/Makefile | 21 ---------------------
>  1 file changed, 21 deletions(-)
>
> diff --git a/tools/testing/selftests/memfd/Makefile b/tools/testing/selftests/memfd/Makefile
> index ad4ab01..b80cd10 100644
> --- a/tools/testing/selftests/memfd/Makefile
> +++ b/tools/testing/selftests/memfd/Makefile
> @@ -1,38 +1,17 @@
> -uname_M := $(shell uname -m 2>/dev/null || echo not)
> -ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/i386/)
> -ifeq ($(ARCH),i386)
> -       ARCH := x86
> -endif
> -ifeq ($(ARCH),x86_64)
> -       ARCH := x86
> -endif
> -
>  CFLAGS += -D_FILE_OFFSET_BITS=64
> -CFLAGS += -I../../../../arch/x86/include/generated/uapi/
> -CFLAGS += -I../../../../arch/x86/include/uapi/
>  CFLAGS += -I../../../../include/uapi/
>  CFLAGS += -I../../../../include/
>
>  all:
> -ifeq ($(ARCH),x86)
>         gcc $(CFLAGS) memfd_test.c -o memfd_test
> -else
> -       echo "Not an x86 target, can't build memfd selftest"
> -endif
>
>  run_tests: all
> -ifeq ($(ARCH),x86)
>         gcc $(CFLAGS) memfd_test.c -o memfd_test
> -endif
>         @./memfd_test || echo "memfd_test: [FAIL]"
>
>  build_fuse:
> -ifeq ($(ARCH),x86)
>         gcc $(CFLAGS) fuse_mnt.c `pkg-config fuse --cflags --libs` -o fuse_mnt
>         gcc $(CFLAGS) fuse_test.c -o fuse_test
> -else
> -       echo "Not an x86 target, can't build memfd selftest"
> -endif
>
>  run_fuse: build_fuse
>         @./run_fuse_test.sh || echo "fuse_test: [FAIL]"
> --
> 2.1.0
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/