linux-kernel - Re: [PATCH 7/7] check for O_NONBLOCK in all read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140917134702.GB10720@thunk.org>
Date:	Wed, 17 Sep 2014 09:47:02 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Benjamin LaHaise <bcrl@...ck.org>
Cc:	Dave Chinner <david@...morbit.com>,
	Milosz Tanski <milosz@...in.com>,
	Jeff Moyer <jmoyer@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Christoph Hellwig <hch@...radead.org>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	linux-aio@...ck.org, Mel Gorman <mgorman@...e.de>,
	Volker Lendecke <Volker.Lendecke@...net.de>,
	Tejun Heo <tj@...nel.org>
Subject: Re: [PATCH 7/7] check for O_NONBLOCK in all read_iter instances

On Wed, Sep 17, 2014 at 08:24:48AM -0400, Benjamin LaHaise wrote:
> 
> Linus flamed me for that a few weeks ago.  The problem is that if one 
> uses "git format-patch" to prepare a series of emails to post, that it 
> users the patch's author for the From: entry.  I think that is a bug 
> in git since multiple people have encountered this issue.  It's not 
> like git doesn't know what one's email address is....

That's true, but "git send-email" takes care of doing the rewrite so
that your e-mail address is on the from line and the original author's
from: line is moved into the body of the e-mail:

% git log -1
commit 1419b5ae0b3bf093bd694dd592ebfdb58ac92d10
Author: Michael Forney <forney@...gle.com>
Date:   Mon Sep 15 14:30:00 2014 -0400

    Don't clear BUILD_CFLAGS and BUILD_LDFLAGS when cross-compiling
    
    Signed-off-by: Michael Forney <forney@...gle.com>
    Signed-off-by: Theodore Ts'o <tytso@....edu>
% git format-patch -o /tmp/p -1
/tmp/p/0001-Don-t-clear-BUILD_CFLAGS-and-BUILD_LDFLAGS-when-cros.patch
% head -5 /tmp/p/0001-Don-t-clear-BUILD_CFLAGS-and-BUILD_LDFLAGS-when-cros.patch 
>From 1419b5ae0b3bf093bd694dd592ebfdb58ac92d10 Mon Sep 17 00:00:00 2001
From: Michael Forney <forney@...gle.com>
Date: Mon, 15 Sep 2014 14:30:00 -0400
Subject: [PATCH] Don't clear BUILD_CFLAGS and BUILD_LDFLAGS when
 cross-compiling
% git send-email /tmp/p --to tytso@....edu
/tmp/p/0001-Don-t-clear-BUILD_CFLAGS-and-BUILD_LDFLAGS-when-cros.patch
(mbox) Adding cc: Michael Forney <forney@...gle.com> from line 'From: Michael Forney <forney@...gle.com>'
(body) Adding cc: Michael Forney <forney@...gle.com> from line 'Signed-off-by: Michael Forney <forney@...gle.com>'
(body) Adding cc: Theodore Ts'o <tytso@....edu> from line 'Signed-off-by: Theodore Ts'o <tytso@....edu>'

From: Theodore Ts'o <tytso@....edu>
To: tytso@....edu
Cc: Michael Forney <forney@...gle.com>
Subject: [PATCH] Don't clear BUILD_CFLAGS and BUILD_LDFLAGS when cross-compiling
Date: Wed, 17 Sep 2014 09:45:09 -0400
Message-Id: <1410961509-10620-1-git-send-email-tytso@....edu>
X-Mailer: git-send-email 2.1.0

Send this email? ([y]es|[n]o|[q]uit|[a]ll): ^C

% git version
git version 2.1.0

Perhaps you and other people are using your own scripts, and not using
git send-email?


							- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/