linux-kernel - Re: [PATCH v3 02/12] btrfs: LLVMLinux: Remove VLAIS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54199160.7090401@fb.com>
Date:	Wed, 17 Sep 2014 09:49:20 -0400
From:	Chris Mason <clm@...com>
To:	<behanw@...verseincode.com>, <agk@...hat.com>,
	<davem@...emloft.net>, <dm-devel@...hat.com>, <fabf@...net.be>,
	<herbert@...dor.apana.org.au>, <jbacik@...com>,
	<snitzer@...hat.com>, <tadeusz.struk@...el.com>
CC:	<akpm@...ux-foundation.org>, <bruce.w.allan@...el.com>,
	<d.kasatkin@...sung.com>, <james.l.morris@...cle.com>,
	<john.griffin@...el.com>, <linux-btrfs@...r.kernel.org>,
	<linux-crypto@...r.kernel.org>,
	<linux-ima-devel@...ts.sourceforge.net>,
	<linux-ima-user@...ts.sourceforge.net>,
	<linux-kernel@...r.kernel.org>, <linux-raid@...r.kernel.org>,
	<linux-security-module@...r.kernel.org>, <neilb@...e.de>,
	<qat-linux@...el.com>, <serge@...lyn.com>,
	<thomas.lendacky@....com>, <zohar@...ux.vnet.ibm.com>,
	<torvalds@...ux-foundation.org>,
	Vinícius Tinti <viniciustinti@...il.com>
Subject: Re: [PATCH v3 02/12] btrfs: LLVMLinux: Remove VLAIS



On 09/15/2014 03:30 AM, behanw@...verseincode.com wrote:
> From: Vinícius Tinti <viniciustinti@...il.com>
> 
> Replaced the use of a Variable Length Array In Struct (VLAIS) with a C99
> compliant equivalent. This is the original VLAIS struct.
> 
> struct {
> 	struct shash_desc shash;
> 	char ctx[crypto_shash_descsize(tfm)];
> } desc;
> 
> This patch instead allocates the appropriate amount of memory using a
> char array using the SHASH_DESC_ON_STACK macro.
> 
> The new code can be compiled with both gcc and clang.
> 
> Signed-off-by: Vinícius Tinti <viniciustinti@...il.com>
> Reviewed-by: Jan-Simon Möller <dl9pf@....de>
> Reviewed-by: Mark Charlebois <charlebm@...il.com>
> Signed-off-by: Behan Webster <behanw@...verseincode.com>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Herbert Xu <herbert@...dor.apana.org.au>

Acked-by: Chris Mason <clm@...com>

On the btrfs bits.  Thanks for the v3.

-chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/