linux-kernel - Re: [PATCH v2] x86/pmc_atom: Fix warning when CONFIG_DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5419986A.9000302@martingkelly.com>
Date:	Wed, 17 Sep 2014 07:19:22 -0700
From:	Martin Kelly <martin@...tingkelly.com>
To:	Ingo Molnar <mingo@...nel.org>
CC:	x86@...nel.org, mingo@...hat.com, vishwesh.m.rudramuni@...el.com,
	joe@...ches.com, hpa@...ux.intel.com, aubrey.li@...ux.intel.com,
	linux-kernel@...r.kernel.org, Martin Kelly <martkell@...zon.com>
Subject: Re: [PATCH v2] x86/pmc_atom: Fix warning when CONFIG_DEBUG_FS=n

On 09/17/2014 05:24 AM, Ingo Molnar wrote:
> 
> Just to paint the bike shed a bit, this could be further 
> simplified to something like:
> 
> 	...
> 
>   	ret = pmc_dbgfs_register(pmc, pdev);
>   	if (ret)
>   		iounmap(pmc->regmap);
> 
>   	return ret;
> 
> and then your patch will be perfect! :-)
> 

Yes, good idea. I sent a v3 with that implemented.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/